Commit Graph

198 Commits

Author SHA1 Message Date
3c27aa6bcd Prioritise static value type for dictionary properties 2025-04-09 22:03:15 +01:00
302fa831cc Initial editor accessibility. 2025-04-08 20:25:48 +03:00
0a1851032b Use the correct root inspector when making elements moved in an array visible 2025-03-29 12:40:26 +08:00
10f6c01b9c Remove ABS in favor of Math::abs 2025-03-19 13:52:40 +01:00
6f25babd6b Remove empty constructors and destructors from editor/ 2025-03-17 21:20:02 +01:00
d0cff82841 Check for empty string for allowed type and allowed subtypes 2025-03-14 22:36:16 +01:00
409fe3c944 Merge pull request #102534 from ttencate/feature/drag_drop_into_array
Improve drag and drop into array property editors
2025-03-14 10:06:06 -05:00
331a43a9d8 Add String::remove_char(s) methods for performance and convenience 2025-03-10 13:19:28 +01:00
466590d0ec Use get_slicec instead of get_slice for single character splitters 2025-03-08 20:36:37 +01:00
93d342b745 Allow dragging items onto array property editor Add Element button
Instead of having to first click the button, then drag the item into the
new slot, this allows just dragging the item onto the button directly.
The button is highlighted as a valid drop target to signal this.
2025-03-08 19:28:05 +01:00
b557840af5 Allow dragging resources (not just files) onto array property editor
The most common scenario is dragging a file from the filesystem dock,
which drags it as type "file", not "resource". This already worked. This
change also makes it possible to drag a resource from another property
editor.
2025-03-08 19:28:05 +01:00
11b3900a0e Allow dragging custom node types onto array property editor
For example, an Array[MyScript] property now accepts any node with the
script MyScript on it. This works for Node and NodePath arrays alike,
and also with the @export_node_path annotation.
2025-03-08 19:28:05 +01:00
0c46089d1b Allow dragging custom resources onto array property editor
This duplicates some of the logic in EditorResourcePicker, but that's
unavoidable: EditorResourcePicker works on a single, loaded resource,
whereas we'd like this to be efficient and not need to load all
(potentially many) dragged resources. Instead, we use the
EditorFileSystem cache to get the information we need.

Note that EditorResourcePicker also supports some automatic conversions,
such as from Shader to ShaderMaterial. This change does not attempt to
make that work for arrays as well.
2025-03-08 19:27:51 +01:00
3c43508ed7 Merge pull request #102427 from AThousandShips/fix_substr
Clean up some uses of `String::substr`
2025-03-07 15:12:33 -06:00
1237536364 Merge pull request #102630 from KoBeWi/what_the_loop
Improve `_is_drop_valid()` code in EditorPropertyArray
2025-03-07 15:12:28 -06:00
5113022dfe Clean up some uses of String::substr
Cases where the end position is either equvalent to the default or past
the end of the string.
2025-03-07 14:50:38 +01:00
62aa4a6f9e Make EditorProperty and its child EditorProperties behave more like sibling nodes
Let `EditorProperty::gui_input()` no longer handle mouse events that
occur in the child EditorProperty rect.
2025-02-28 07:40:04 +08:00
b9a60574b4 Improve _is_drop_valid() code in EditorPropertyArray 2025-02-09 20:36:14 +01:00
bbfbde99e9 Hide slider for array size selector in editor
Use `editing_integer` so that editor has step buttons
2025-02-04 16:04:02 -08:00
7d185473bf Merge pull request #96623 from ajreckof/avoid-bubbling-up-changed-notification-when-on-new-item/key-of-dictionaries-to-avoid-inspector-whipeout-
Avoid bubbling up changed notification when on new item/key of dictionaries to avoid inspector wipeout.
2025-01-27 09:46:19 -06:00
4c4f29a490 Fix several i18n issues in editor 2025-01-26 16:41:10 +08:00
d6adc775a4 Merge pull request #89763 from ajreckof/fix-focus-on-reorder
Fix focus when reordering array
2025-01-16 17:17:42 -06:00
b8860f1c11 Fix non-typed Dictionary keys displayed as <null> in the inspector. 2025-01-09 11:38:17 +02:00
452f1fa0e9 Merge pull request #100512 from bruvzg/dict_keys
[Dictionary Property Editor] Use property editors instead of labels to display keys.
2025-01-07 00:45:00 +01:00
ba3f2bf4a3 Fix dictionary editor steals focus when reloading script. 2024-12-30 16:28:06 +01:00
f241c1fda0 Remove unused header in editor.
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
2024-12-24 00:40:38 +08:00
1e982a49c3 [Dictionary Property Editor] Use property editors instead of labels to display keys. 2024-12-18 08:14:38 +02:00
68f638cf02 Use (r)find_char instead of (r)find for single characters 2024-11-17 10:02:18 +01:00
f5431fe3f0 Merge pull request #98220 from bruvzg/dict_ed_fix
[Editor] Fix dictionary editor removing wrong keys and not updating key labels.
2024-11-15 10:42:37 -06:00
562c666e3d Rename internal Button icon to button_icon to match exposed methods 2024-10-29 16:23:03 -07:00
cbc8468e3e [Editor] Fix dictionary editor removing wrong keys and not updating key labels. 2024-10-16 10:35:39 +03:00
72f4394d8c avoid bubbling up changed notification when on new item/key of dictionaries to avoid inspector whipeout. 2024-09-06 18:33:44 +02:00
9853a69144 Implement typed dictionaries 2024-09-04 10:27:26 -05:00
51c7ff86ff Merge pull request #94522 from RoyBerardo/move-array-dict-remove-item
Make "Remove Item" appear at the top of the list when editing the value of an array or dictionary
2024-08-28 09:45:31 +02:00
065dd099dd Remove empty bind_methods() 2024-08-15 08:24:32 +02:00
6577a39bd0 Fix label update for dict on item deletion. 2024-08-10 23:25:46 +02:00
d113a68e43 fix focus on reorder array 2024-08-10 23:24:42 +02:00
f46e94d460 Fix Object encoded as id in dictionnaries to be represented as int in the inspector. 2024-07-22 09:53:03 +02:00
298432317d Make "Remove Item" appear at the top of the list that appears when editing the type of value in an array or dictionary 2024-07-19 03:14:47 -07:00
f0da5cac7b Always call _can_handle() before _parse_property() 2024-06-26 13:10:08 +02:00
fbb879debd [Scene] Add SceneStringNames::text/value_changed 2024-06-19 09:44:38 +02:00
c31111f5ec Editor: Focus value editor on type change in Dictionary and Array editors 2024-06-04 16:51:29 +02:00
926afccbd8 [Scene] Add SceneStringNames::panel 2024-05-30 22:54:50 +02:00
755a0efbb6 [Scene] Add SceneStringNames::id_pressed 2024-05-30 22:54:04 +02:00
25519867f2 Merge pull request #92225 from ajreckof/fix-multiline-array
Fix array variable with `@export_multiline` not registering changes.
2024-05-29 23:11:57 +02:00
f764c5336a Fix crash on dictionary initialization after return to default in C#. 2024-05-25 11:12:10 +02:00
0e8abb5132 Fix array variable with@export_multiline not registering changes. 2024-05-21 22:57:32 +02:00
ee79386f7b [Scene] Add SceneStringNames::pressed 2024-05-14 15:51:28 +02:00
413c11357d Use Core/Scene stringnames consistently 2024-05-13 23:41:07 +02:00
114ab9dd04 fix infinite call loop on theme change.
Apply suggestions from code review
2024-05-13 14:39:02 +02:00