northern-lighthouse/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #73291 from vonagam/fix-unsafe-weak-binop

Browse Source 
GDScript: Fix missing unsafety mark for binary op with weak variables
This commit is contained in:
Rémi Verschelde
2023-02-20 15:41:32 +01:00
parent 3e0a989bd1 df6aae2eca
commit 6bf63a3542
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/gdscript/gdscript_analyzer.cpp
View File

@ -2599,6 +2599,8 @@ void GDScriptAnalyzer::reduce_binary_op(GDScriptParser::BinaryOpNode *p_binary_o
result = get_operation_type(p_binary_op->variant_op, left_type, right_type, valid, p_binary_op); result = get_operation_type(p_binary_op->variant_op, left_type, right_type, valid, p_binary_op);
if (!valid) { if (!valid) {
push_error(vformat(R"(Invalid operands "%s" and "%s" for "%s" operator.)", left_type.to_string(), right_type.to_string(), Variant::get_operator_name(p_binary_op->variant_op)), p_binary_op); push_error(vformat(R"(Invalid operands "%s" and "%s" for "%s" operator.)", left_type.to_string(), right_type.to_string(), Variant::get_operator_name(p_binary_op->variant_op)), p_binary_op);
} else if (result.type_source != GDScriptParser::DataType::ANNOTATED_EXPLICIT) {
mark_node_unsafe(p_binary_op);
} }
} else { } else {
ERR_PRINT("Parser bug: unknown binary operation."); ERR_PRINT("Parser bug: unknown binary operation.");