northern-lighthouse/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

GDScript: fix regression when checking for virtual function implementation.

Browse Source 
Unfortunately it appears the virtual function checks in #77324 are not
trustworthy at runtime, because objects can have scripts attached, but
this information is not always available at compile-time. These checks
need to be removed.

The rest of the PR is still useful, making all method flags available to
the analyzer, so a full revert isn't necessary/desirable.

This reopens #76938, which will need another solution.
This commit is contained in:
ocean (they/them)
2023-06-21 15:13:45 -04:00
parent 28a60b3de0
commit 6c28b8edd3
9 changed files with 0 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/gdscript/tests/scripts/analyzer/errors/virtual_method_not_implemented.gd
View File

@ -1,2 +0,0 @@
func test():
_get_property_list()

2
modules/gdscript/tests/scripts/analyzer/errors/virtual_method_not_implemented.out
View File

@ -1,2 +0,0 @@
GDTEST_ANALYZER_ERROR
Cannot call virtual function "_get_property_list()" because it hasn't been defined.

5
modules/gdscript/tests/scripts/analyzer/errors/virtual_super_not_implemented.gd
View File

@ -1,5 +0,0 @@
func _init():
super()
func test():
pass

2
modules/gdscript/tests/scripts/analyzer/errors/virtual_super_not_implemented.out
View File

@ -1,2 +0,0 @@
GDTEST_ANALYZER_ERROR
Cannot call the parent class' virtual function "_init()" because it hasn't been defined.

11
modules/gdscript/tests/scripts/analyzer/features/virtual_method_implemented.gd
View File

@ -1,11 +0,0 @@
class TestOne:
func _get_property_list():
return {}
class TestTwo extends TestOne:
func _init():
var _x = _get_property_list()
func test():
var x = TestTwo.new()
var _x = x._get_property_list()

1
modules/gdscript/tests/scripts/analyzer/features/virtual_method_implemented.out
View File

@ -1 +0,0 @@
GDTEST_OK

10
modules/gdscript/tests/scripts/analyzer/features/virtual_super_implemented.gd
View File

@ -1,10 +0,0 @@
class TestOne:
func _init():
pass
class TestTwo extends TestOne:
func _init():
super()
func test():
pass

1
modules/gdscript/tests/scripts/analyzer/features/virtual_super_implemented.out
View File

@ -1 +0,0 @@
GDTEST_OK