northern-lighthouse/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #32477 from aaronfranke/equal-approx-separate

Browse Source 
Make is_equal_approx separate and make == exact again
This commit is contained in:
Rémi Verschelde
2019-11-07 14:54:15 +01:00
committed by GitHub
parent f0fc28f0fd 218f38c7ec
commit 77816fea8b
37 changed files with 198 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/math/plane.cpp
View File

@ -32,9 +32,6 @@
#include "core/math/math_funcs.h"
#define _PLANE_EQ_DOT_EPSILON 0.999
#define _PLANE_EQ_D_EPSILON 0.0001
void Plane::set_normal(const Vector3 &p_normal) {
normal = p_normal;
@ -156,9 +153,9 @@ bool Plane::intersects_segment(const Vector3 &p_begin, const Vector3 &p_end, Vec
/* misc */
bool Plane::is_almost_like(const Plane &p_plane) const {
bool Plane::is_equal_approx(const Plane &p_plane) const {
return (normal.dot(p_plane.normal) > _PLANE_EQ_DOT_EPSILON && Math::absd(d - p_plane.d) < _PLANE_EQ_D_EPSILON);
return normal.is_equal_approx(p_plane.normal) && Math::is_equal_approx(d, p_plane.d);
}
Plane::operator String() const {