seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

When overlappinng Area2Ds are removed with remove_child(), _enter_tree and _exit_tree signals are now properly disconnected upon removal

Browse Source
This commit is contained in:
lonesurvivor
2017-01-25 20:52:44 +01:00
parent 430f3e6043
commit 9cddaab4d1
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
scene/2d/area_2d.cpp
View File

@ -357,6 +357,10 @@ void Area2D::_clear_monitoring() {
Object *obj = ObjectDB::get_instance(E->key()); Object *obj = ObjectDB::get_instance(E->key());
Node *node = obj ? obj->cast_to<Node>() : NULL; Node *node = obj ? obj->cast_to<Node>() : NULL;
ERR_CONTINUE(!node); ERR_CONTINUE(!node);
node->disconnect(SceneStringNames::get_singleton()->tree_entered,this,SceneStringNames::get_singleton()->_body_enter_tree);
node->disconnect(SceneStringNames::get_singleton()->tree_exited,this,SceneStringNames::get_singleton()->_body_exit_tree);
if (!E->get().in_tree) if (!E->get().in_tree)
continue; continue;
@ -366,9 +370,6 @@ void Area2D::_clear_monitoring() {
} }
emit_signal(SceneStringNames::get_singleton()->body_exited,obj); emit_signal(SceneStringNames::get_singleton()->body_exited,obj);
node->disconnect(SceneStringNames::get_singleton()->tree_entered,this,SceneStringNames::get_singleton()->_body_enter_tree);
node->disconnect(SceneStringNames::get_singleton()->tree_exited,this,SceneStringNames::get_singleton()->_body_exit_tree);
} }
} }
@ -388,6 +389,9 @@ void Area2D::_clear_monitoring() {
continue; continue;
//ERR_CONTINUE(!node); //ERR_CONTINUE(!node);
node->disconnect(SceneStringNames::get_singleton()->tree_entered,this,SceneStringNames::get_singleton()->_area_enter_tree);
node->disconnect(SceneStringNames::get_singleton()->tree_exited,this,SceneStringNames::get_singleton()->_area_exit_tree);
if (!E->get().in_tree) if (!E->get().in_tree)
continue; continue;
@ -397,9 +401,6 @@ void Area2D::_clear_monitoring() {
} }
emit_signal(SceneStringNames::get_singleton()->area_exited,obj); emit_signal(SceneStringNames::get_singleton()->area_exited,obj);
node->disconnect(SceneStringNames::get_singleton()->tree_entered,this,SceneStringNames::get_singleton()->_area_enter_tree);
node->disconnect(SceneStringNames::get_singleton()->tree_exited,this,SceneStringNames::get_singleton()->_area_exit_tree);
} }
} }