Unify String and StringName
This commit is contained in:
@ -1252,9 +1252,30 @@ GDScriptCodeGenerator::Address GDScriptCompiler::_parse_match_pattern(CodeGen &c
|
||||
equality_type.kind = GDScriptDataType::BUILTIN;
|
||||
equality_type.builtin_type = Variant::BOOL;
|
||||
|
||||
GDScriptCodeGenerator::Address type_string_addr = codegen.add_constant(Variant::STRING);
|
||||
GDScriptCodeGenerator::Address type_string_name_addr = codegen.add_constant(Variant::STRING_NAME);
|
||||
|
||||
// Check type equality.
|
||||
GDScriptCodeGenerator::Address type_equality_addr = codegen.add_temporary(equality_type);
|
||||
codegen.generator->write_binary_operator(type_equality_addr, Variant::OP_EQUAL, p_type_addr, literal_type_addr);
|
||||
|
||||
// Check if StringName <-> String comparison is possible.
|
||||
GDScriptCodeGenerator::Address type_comp_addr_1 = codegen.add_temporary(equality_type);
|
||||
GDScriptCodeGenerator::Address type_comp_addr_2 = codegen.add_temporary(equality_type);
|
||||
|
||||
codegen.generator->write_binary_operator(type_comp_addr_1, Variant::OP_EQUAL, p_type_addr, type_string_addr);
|
||||
codegen.generator->write_binary_operator(type_comp_addr_2, Variant::OP_EQUAL, literal_type_addr, type_string_name_addr);
|
||||
codegen.generator->write_binary_operator(type_comp_addr_1, Variant::OP_AND, type_comp_addr_1, type_comp_addr_2);
|
||||
codegen.generator->write_binary_operator(type_equality_addr, Variant::OP_OR, type_equality_addr, type_comp_addr_1);
|
||||
|
||||
codegen.generator->write_binary_operator(type_comp_addr_1, Variant::OP_EQUAL, p_type_addr, type_string_name_addr);
|
||||
codegen.generator->write_binary_operator(type_comp_addr_2, Variant::OP_EQUAL, literal_type_addr, type_string_addr);
|
||||
codegen.generator->write_binary_operator(type_comp_addr_1, Variant::OP_AND, type_comp_addr_1, type_comp_addr_2);
|
||||
codegen.generator->write_binary_operator(type_equality_addr, Variant::OP_OR, type_equality_addr, type_comp_addr_1);
|
||||
|
||||
codegen.generator->pop_temporary(); // Remove type_comp_addr_2 from stack.
|
||||
codegen.generator->pop_temporary(); // Remove type_comp_addr_1 from stack.
|
||||
|
||||
codegen.generator->write_and_left_operand(type_equality_addr);
|
||||
|
||||
// Get literal.
|
||||
|
||||
Reference in New Issue
Block a user